[PATCH] D138084: [LoongArch] Support when the depth of __builtin_frame_address is greater than zero

[Gong LingQin via Phabricator via llvm-commits]

gonglingqin created this revision.
gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
gonglingqin requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

As discussed in D137541 <https://reviews.llvm.org/D137541>, it supports processing when the depth of
__builtin_frame_address is greater than 0 instead of reporting an error.
Unsafe calls rely on the '-Wframe-address' option for diagnosis.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138084

Files:
  llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp
  llvm/test/CodeGen/LoongArch/frameaddr-returnaddr-error.ll
  llvm/test/CodeGen/LoongArch/frameaddr-returnaddr.ll


Index: llvm/test/CodeGen/LoongArch/frameaddr-returnaddr.ll
===================================================================
--- llvm/test/CodeGen/LoongArch/frameaddr-returnaddr.ll
+++ llvm/test/CodeGen/LoongArch/frameaddr-returnaddr.ll
@@ -33,6 +33,36 @@
   ret ptr %1
 }
 
+define ptr @test_frameaddress_2() nounwind {
+; LA32-LABEL: test_frameaddress_2:
+; LA32:       # %bb.0:
+; LA32-NEXT:    addi.w $sp, $sp, -16
+; LA32-NEXT:    st.w $ra, $sp, 12 # 4-byte Folded Spill
+; LA32-NEXT:    st.w $fp, $sp, 8 # 4-byte Folded Spill
+; LA32-NEXT:    addi.w $fp, $sp, 16
+; LA32-NEXT:    ld.w $a0, $fp, -8
+; LA32-NEXT:    ld.w $a0, $a0, -8
+; LA32-NEXT:    ld.w $fp, $sp, 8 # 4-byte Folded Reload
+; LA32-NEXT:    ld.w $ra, $sp, 12 # 4-byte Folded Reload
+; LA32-NEXT:    addi.w $sp, $sp, 16
+; LA32-NEXT:    ret
+;
+; LA64-LABEL: test_frameaddress_2:
+; LA64:       # %bb.0:
+; LA64-NEXT:    addi.d $sp, $sp, -16
+; LA64-NEXT:    st.d $ra, $sp, 8 # 8-byte Folded Spill
+; LA64-NEXT:    st.d $fp, $sp, 0 # 8-byte Folded Spill
+; LA64-NEXT:    addi.d $fp, $sp, 16
+; LA64-NEXT:    ld.d $a0, $fp, -16
+; LA64-NEXT:    ld.d $a0, $a0, -16
+; LA64-NEXT:    ld.d $fp, $sp, 0 # 8-byte Folded Reload
+; LA64-NEXT:    ld.d $ra, $sp, 8 # 8-byte Folded Reload
+; LA64-NEXT:    addi.d $sp, $sp, 16
+; LA64-NEXT:    ret
+  %1 = call ptr @llvm.frameaddress(i32 2)
+  ret ptr %1
+}
+
 define ptr @test_returnaddress_0() nounwind {
 ; LA32-LABEL: test_returnaddress_0:
 ; LA32:       # %bb.0:
Index: llvm/test/CodeGen/LoongArch/frameaddr-returnaddr-error.ll
===================================================================
--- llvm/test/CodeGen/LoongArch/frameaddr-returnaddr-error.ll
+++ llvm/test/CodeGen/LoongArch/frameaddr-returnaddr-error.ll
@@ -16,13 +16,6 @@
   ret ptr %1
 }
 
-define ptr @non_zero_frameaddress() nounwind {
-; CHECK: frame address can only be determined for the current frame
-  %1 = call ptr @llvm.frameaddress(i32 1)
-  ret ptr %1
-}
-
-
 define ptr @non_zero_returnaddress() nounwind {
 ; CHECK: return address can only be determined for the current frame
   %1 = call ptr @llvm.returnaddress(i32 1)
Index: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp
===================================================================
--- llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp
+++ llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp
@@ -254,19 +254,23 @@
     return SDValue();
   }
 
-  // Currently only support lowering frame address for current frame.
-  if (cast<ConstantSDNode>(Op.getOperand(0))->getZExtValue() != 0) {
-    DAG.getContext()->emitError(
-        "frame address can only be determined for the current frame");
-    return SDValue();
-  }
-
   MachineFunction &MF = DAG.getMachineFunction();
   MF.getFrameInfo().setFrameAddressIsTaken(true);
-
-  return DAG.getCopyFromReg(DAG.getEntryNode(), SDLoc(Op),
-                            Subtarget.getRegisterInfo()->getFrameRegister(MF),
-                            Op.getValueType());
+  Register FrameReg = Subtarget.getRegisterInfo()->getFrameRegister(MF);
+  EVT VT = Op.getValueType();
+  SDLoc DL(Op);
+  SDValue FrameAddr = DAG.getCopyFromReg(DAG.getEntryNode(), DL, FrameReg, VT);
+  unsigned Depth = cast<ConstantSDNode>(Op.getOperand(0))->getZExtValue();
+  int GRLenInBytes = Subtarget.getGRLen() / 8;
+
+  while (Depth--) {
+    int Offset = -(GRLenInBytes * 2);
+    SDValue Ptr = DAG.getNode(ISD::ADD, DL, VT, FrameAddr,
+                              DAG.getIntPtrConstant(Offset, DL));
+    FrameAddr =
+        DAG.getLoad(VT, DL, DAG.getEntryNode(), Ptr, MachinePointerInfo());
+  }
+  return FrameAddr;
 }
 
 SDValue LoongArchTargetLowering::lowerRETURNADDR(SDValue Op,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138084.475656.patch
Type: text/x-patch
Size: 3681 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221116/c9508b79/attachment.bin>