[PATCH] D137553: [MemorySSA] Delete dead MemoryUseOrDef for CallInst when clone loop basicblock

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 16:29:08 PST 2022


asbirlea accepted this revision.
asbirlea added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Analysis/MemorySSA.cpp:1768
+    // FIXME: Would Def value always be consistent after transforms?
+    assert(Def == DefCheck && "Invalid template");
 #endif
----------------
Could you add:
```
if (!Def && Use != UseCheck) {
        // New access should not have more power than template access
        assert(!UseCheck && "Invalid template");
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137553/new/

https://reviews.llvm.org/D137553



More information about the llvm-commits mailing list