[PATCH] D137905: [GlobalISel] Add new G_INVOKE_REGION_START/END instructions to fix an EH bug

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Should the invoke just stay as a terminator instead? I'd hate to have more code placement mechanisms



================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:851-855
+G_INVOKE_REGION_END
+^^^^^^^^^^^^^^^^^^^
+
+Marks the end of an invoke region. Instructions generated after this may be
+unreachable.
----------------
Don't see the point of adding an unused instruction 


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/invoke-region.ll:60
+  ret i1 %r.0
+}
----------------
Can you add a case with non-constant phi inputs


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137905/new/

https://reviews.llvm.org/D137905