[PATCH] D137955: [AST] Make AliasSetTracker work on BatchAA
Alina Sbirlea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 15 14:24:18 PST 2022
asbirlea accepted this revision.
asbirlea added a comment.
+1 on making the AST only work on immutable IR.
The only nit from me: allow the constructor to receive AAResults and build the BatchAA instance internally? It would simplify most instantiation sites modified in the patch. It still makes sense to define the BatchAA in some cases (LoopReroll), but I don't see the purpose of keeping the instance in LoopAccessAnalysis. Downside: allocation - which might make it not worth it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137955/new/
https://reviews.llvm.org/D137955
More information about the llvm-commits
mailing list