[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 14:09:56 PST 2022


lebedev.ri added a comment.

In D136806#3928663 <https://reviews.llvm.org/D136806#3928663>, @asbirlea wrote:

> IIUC compile time impact for adding another SROA (the one outside LTO) is negligible?

Yup.

> Regarding the principle of adding another pass and where in the pipeline, we're still at a case by case basis. We had a discussion/round table at LLVM Dev on the documenting the current new pass manager pipeline precisely for understanding pass dependencies and being able to get resolutions on cases such as this. I'm still putting together the summary for that but it should be up on discourse this week.

We really can't achieve the same effect here in any other reasonable way,
without penalizing the inliner pipeline.

> Testing this change in parallel - I'll follow up tomorrow.

Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136806/new/

https://reviews.llvm.org/D136806



More information about the llvm-commits mailing list