[PATCH] D137760: Add FP8 E4M3 support to APFloat.

[Reed Wanderman-Milne via Phabricator via llvm-commits]

reedwm added a comment.

In D137760#3928314 <https://reviews.llvm.org/D137760#3928314>, @stellaraccident wrote:

> Thanks for this. Patch lgtm. Has a couple of format issues but probably ok as-is (this file is very inconsistently formatted and it looks like you overrode clang-format a bit for consistency with adjacent code).

Yeah, I ran clang-format-diff.py, but reverted some changes when inconsistent with the rest of the file. In particular, clang-format-diff.py would unindent parts of structs within a namespace (since clang-format wants no indentation in a namespace but the file uses indentation), and in the test file I ensured added/modified lines in a test function were consistent with the unmodified lines in the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137760/new/

https://reviews.llvm.org/D137760