[PATCH] D138044: AMDGPU/GlobalISel: Fix crash after mad/fma_mix fails selection
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 15 10:17:20 PST 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3418-3421
Register VGPRSrc = MRI->cloneVirtualRegister(OrigSrc);
BuildMI(*UseMI->getParent(), UseMI, UseMI->getDebugLoc(),
TII.get(AMDGPU::COPY), VGPRSrc)
.addReg(Src);
----------------
This copy should just have been restricted in the first place. I also would have expected this to not have produced instructions unless the match happened; can you first try constraining the operands of this copy, and then splitting the predicate part from the instruction construction?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138044/new/
https://reviews.llvm.org/D138044
More information about the llvm-commits
mailing list