[PATCH] D137440: [RISCV][llvm-mca] Use LMUL Instruments to provide more accurate reports on RISCV

Michael Maitland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 08:31:51 PST 2022


michaelmaitland added a comment.

In D137440#3927809 <https://reviews.llvm.org/D137440#3927809>, @thakis wrote:

> Apparently doesn't build on linux either: http://45.33.8.238/linux/91480/step_4.txt
>
> Maybe it's "doesn't' build with clang as host compiler"?
>
> Anyways, thanks for the quick revert!

It was because building with `ninja all` didn't build the x86 unit tests so I didn't catch it. I have fixed the issue on my local machine. What is standard procedure after reverting commit? Do I make an entirely new revision or modify this one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137440/new/

https://reviews.llvm.org/D137440



More information about the llvm-commits mailing list