[PATCH] D137629: [PowerPC] Use default attributes for intrinsics

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 07:52:02 PST 2022


nikic added a comment.

In D137629#3926650 <https://reviews.llvm.org/D137629#3926650>, @shchenz wrote:

> Will there be some functionality issues without adding `DefaultAttrsIntrinsic` for intrinsics that are missing `IntrNoMem` attribute before? Or just performance issues?
>
> I asked because if there are functionality issues, we may need to go through other intrinsics as well. I think there are some other intrinsics need change too, for example `int_ppc_readflm` and `int_ppc_setflm`.

Missing default attributes only cause performance issues, it's not a problem for correctness. But of course, adding default attributes to other intrinsics is definitely useful as well, where possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137629/new/

https://reviews.llvm.org/D137629



More information about the llvm-commits mailing list