[PATCH] D138034: [LegacyPM] remove unset variables in PassManagerBuilder

[Mikhail Goncharov via Phabricator via llvm-commits]

goncharov created this revision.
goncharov added a reviewer: MaskRay.
Herald added subscribers: ormris, StephenFan, hiraditya.
Herald added a reviewer: kmitropoulou.
Herald added a project: All.
goncharov requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

D137915 <https://reviews.llvm.org/D137915> stopped setting this variables but NewGVN was still used and caused asan failure


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138034

Files:
  llvm/include/llvm/Transforms/IPO/PassManagerBuilder.h
  llvm/lib/Transforms/IPO/PassManagerBuilder.cpp


Index: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
===================================================================
--- llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
+++ llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
@@ -234,8 +234,7 @@
 
   if (OptLevel > 1) {
     MPM.add(createMergedLoadStoreMotionPass()); // Merge ld/st in diamonds
-    MPM.add(NewGVN ? createNewGVNPass()
-                   : createGVNPass(DisableGVNLoadPRE)); // Remove redundancies
+    MPM.add(createGVNPass(DisableGVNLoadPRE));  // Remove redundancies
   }
   MPM.add(createSCCPPass());                  // Constant prop with SCCP
 
Index: llvm/include/llvm/Transforms/IPO/PassManagerBuilder.h
===================================================================
--- llvm/include/llvm/Transforms/IPO/PassManagerBuilder.h
+++ llvm/include/llvm/Transforms/IPO/PassManagerBuilder.h
@@ -157,8 +157,6 @@
   bool SLPVectorize;
   bool LoopVectorize;
   bool LoopsInterleaved;
-  bool RerollLoops;
-  bool NewGVN;
   bool DisableGVNLoadPRE;
   bool ForgetAllSCEVInLoopUnroll;
   bool VerifyInput;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138034.475463.patch
Type: text/x-patch
Size: 1075 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221115/f632936e/attachment.bin>