[PATCH] D138027: Clean up CFG on JumpThreading

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Note that for unreachable IR, self-referencing, and other forms of invalidity of IR, is legal.



================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:451
         LoopHeaders.erase(&BB);
         LVI->eraseBlock(&BB);
+        // If the removed block is a predecessor of a loop block
----------------
Would it not be sufficient to just add the block into `Unreachable` set?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138027/new/

https://reviews.llvm.org/D138027