[PATCH] D137767: [AMDGPU] Add aperture register 64 bit variants

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 02:13:00 PST 2022


Pierre-vh updated this revision to Diff 475392.
Pierre-vh added a comment.

Comments

I wasn't able to do this without creating the 16 bit subregisters.
I added a FIXME for it. If I don't add them and try to just define the
32 bit register directly using SIReg, it creates a lot of issues with register pressure sets and classes.
We end up with a bunch of autogenerated ones that are useless and just cause crashes everywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137767/new/

https://reviews.llvm.org/D137767

Files:
  llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
  llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
  llvm/lib/Target/AMDGPU/SIRegisterInfo.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137767.475392.patch
Type: text/x-patch
Size: 8263 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221115/598c5565/attachment.bin>


More information about the llvm-commits mailing list