[PATCH] D137955: [AST] Make AliasSetTracker work on BatchAA

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 02:11:12 PST 2022


nikic added a comment.

In D137955#3925704 <https://reviews.llvm.org/D137955#3925704>, @reames wrote:

> I have no problem with the idea of the patch, but I think this needs to be split into two patches.
>
> The first simply removes support for ASTs over mutating IR, and makes the API changes required.  (Note the suggestion about asserting value handl inline.)  This should land on it's own so that if we missed a remaining mutation point, we get a chance to smoke out the failure without reasoning about potential confusing AA results at the same time.

That's a good point! I've split the patch up into two parts now, and replaced the CallbackVH use with AssertVH as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137955/new/

https://reviews.llvm.org/D137955



More information about the llvm-commits mailing list