[PATCH] D137824: [WebAssembly] multivalue stackify fix
Sam Parker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 15 01:13:58 PST 2022
samparker added inline comments.
================
Comment at: llvm/test/CodeGen/WebAssembly/multivalue-dont-move-def-past-use.mir:10
+
+ define hidden fp128 @e() local_unnamed_addr #0 {
+ %1 = load double, ptr @d, align 8
----------------
tlively wrote:
> Is it possible to come up with a reproducer with a single basic block? Either way, it would be helpful to add comments highlighting the important pieces of the test. There's enough going on here that it's difficult to figure out which parts are important just by looking at it.
Yeah, good point. I'll take the reproducer from [[ https://github.com/llvm/llvm-project/issues/55136#issuecomment-1185493030 | here ]] since trying to simplify fp128 lowering is too much work!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137824/new/
https://reviews.llvm.org/D137824
More information about the llvm-commits
mailing list