[PATCH] D137982: [pgo] Avoid introducing relocations by using private alias

[Paul Kirth via Phabricator via llvm-commits]

paulkirth marked an inline comment as done.
paulkirth added inline comments.


================
Comment at: llvm/test/Transforms/PGOProfile/prof_avoid_relocs.ll:26
+
+define void @perform_merge(ptr %val, i32 %counter11, i32 %counter12, i32 %counter22, i32 %counter21) {
+entry:
----------------
phosek wrote:
> Does this check anything beyond what's already checked by `my_foo`, `my_bar` and `my_baz` below? Could we just a single function (e.g. `my_foo) to simplify this test?
That's a good point. I've simplified the test significantly. I added a sanity check for the function body that its instrumented as expected, but that could be removed too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137982/new/

https://reviews.llvm.org/D137982