[PATCH] D138003: [RISCV] Refactor getDefaultVLOps. NFC.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1853
 
+static SDValue getDefaultVLOps(uint64_t NumElts, SDLoc DL, SelectionDAG &DAG,
+                               const RISCVSubtarget &Subtarget) {
----------------
"Default" doesn't make sense anymore.

And it `Ops` shouldn't be plural if it returns a single value.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1857
+  SDValue VL = DAG.getConstant(NumElts, DL, XLenVT);
+  return VL;
+}
----------------
This can be shorted to

```
return DAG.getConstant(NumElts, DL, Subtarget.getXLenVT());
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138003/new/

https://reviews.llvm.org/D138003