[PATCH] D136233: [SimpleLoopUnswitch] Insert loop-invariant conditions and unswitch them when it's profitable

[Artur Pilipenko via Phabricator via llvm-commits]

apilipenko added a comment.

A couple of high-level comments.

How does this type of unswitching interact with poison?

I'm not fond of the term "virtual" here as it is very non-descriptive. I don't have a great suggestion, but maybe "unswitch by injected invariants" or something like this?

Looks like you are doing some canonicalization of conditions in this patch: replacing signed with unsigned, handling zexts. I suggest splitting all of this into separate patches so as to make the initial review smaller. Leave the bare minimum transform in the initial patch and then layer complexity with follow up reviews.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136233/new/

https://reviews.llvm.org/D136233