[PATCH] D137398: lib/CodeGen: Compile with -fvisibility=hidden when possible

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D137398#3925885 <https://reviews.llvm.org/D137398#3925885>, @compnerd wrote:

> I do like the idea in concept less in practice.  The problem is that this is specific to the ELFish targets.  I would prefer to handle this like my previously suggested approach of annotations (see D109192 <https://reviews.llvm.org/D109192>).

Well they're not mutually exclusive either. The existing approach with visibility works for some configurations, and can be extended to cover more areas of the libraries, without blocking D109192 <https://reviews.llvm.org/D109192> when that is ready in a mergeable shape, right?

(FWIW, hidden visibility is usable on mingw targets these days too, so it's not only ELF.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137398/new/

https://reviews.llvm.org/D137398