[PATCH] D137851: [OPENMP]Initial support for at clause

[Jennifer Yu via Phabricator via llvm-commits]

jyu2 added inline comments.


================
Comment at: clang/include/clang/Sema/Sema.h:11293
+                                       SourceLocation EndLoc,
+                                       bool InExContext = true);
   /// Called on well-formed '\#pragma omp barrier'.
----------------
ABataev wrote:
> Why do you need this flag?
The error pragma is not allowed in declared context when "at" clause with execution modifier. 
It is allowed with compilation modifier.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:11035-11037
+  for (auto *AC :
+       OMPExecutableDirective::getClausesOfKind<OMPAtClause>(Clauses))
+    AtC = AC;
----------------
ABataev wrote:
> Why do you need a loop here?
Only one "at" clause is allowed.  So I think Loop does not matters.  Changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137851/new/

https://reviews.llvm.org/D137851