[PATCH] D137954: Enable roundeven.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 14 10:37:05 PST 2022
arsenm added a comment.
In D137954#3925019 <https://reviews.llvm.org/D137954#3925019>, @Leonc wrote:
> In D137954#3925014 <https://reviews.llvm.org/D137954#3925014>, @arsenm wrote:
>
>> Can you also take care of globalisel here?
>
> From what I can tell globalisel already has support.
Tests should be unified then
================
Comment at: llvm/test/CodeGen/AMDGPU/roundeven.ll:16
+; GFX6-NEXT: v_cvt_f32_f16_e32 v0, v0
+; GFX6-NEXT: v_trunc_f32_e32 v2, v0
+; GFX6-NEXT: v_bfi_b32 v1, s4, 1.0, v0
----------------
Leonc wrote:
> arsenm wrote:
> > Does v_trunc_f32 ever raise FP exceptions?
> I assume we have tests for that in a different file, but if not I could make a new task to add them.
That's not testable here, it's an isa behavior question
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137954/new/
https://reviews.llvm.org/D137954
More information about the llvm-commits
mailing list