[PATCH] D137963: DAG: Fix assert on load casted to vector with attached range metadata

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 10:36:05 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:3463
+          computeKnownBitsFromRangeMetadata(*Ranges, KnownFull);
+          Known = KnownFull.trunc(BitWidth);
+        } else
----------------
RKSimon wrote:
> is this correct for big-endian cases?
Probably not. Ideally ranges would naturally support vectors and the integer could be casted into a vector of ranges, but they don't


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137963/new/

https://reviews.llvm.org/D137963



More information about the llvm-commits mailing list