[PATCH] D137574: PEI should be able to use backward walk in replaceFrameIndicesBackward.

[Alexander via Phabricator via llvm-commits]

alex-t marked an inline comment as done.
alex-t added inline comments.


================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1505-1506
+    // Shift it to make RS collect reg info up to the current instruction.
+    if (Step != BB->begin())
+      Step--;
+
----------------
arsenm wrote:
> Do we have test coverage for a frame index that needs to be handled as the very first and very last instruction in the block? If not, we need them 
We already have a case for the FI at the BB's beginning: func_add_constant_to_fi_uniform_SCC_clobber_i32 in frame-index.mir
I have added the case for the FI at the end.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137574/new/

https://reviews.llvm.org/D137574