[PATCH] D137851: [OPENMP]Initial support for at clause

[Jennifer Yu via Phabricator via llvm-commits]

jyu2 added inline comments.


================
Comment at: clang/include/clang/Parse/Parser.h:3302
+  void ParseOpenMPClauses(OpenMPDirectiveKind DKind,
+                          SmallVector<clang::OMPClause *, 1> *Clauses,
+                          SourceLocation Loc);
----------------
ABataev wrote:
> `SmallVectorImpl<OMPClause *> &`
Thanks!! Changed.


================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:1656-1657
+    OMPAtClause *AtC = CKind == OMPC_at ? cast<OMPAtClause>(Clause) : nullptr;
+    if (CKind == OMPC_at && AtC->getAtKind() == OMPC_AT_execution)
+      Diag(AtC->getAtKindKwLoc(), diag::err_omp_unexpected_execution_modifier);
+    if (Tok.is(tok::annot_pragma_openmp_end)) {
----------------
ABataev wrote:
> Better to diagnose it in Sema
Move to Sema!!  Changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137851/new/

https://reviews.llvm.org/D137851