[PATCH] D137934: [InstCombine] Fold extractelt with select of constants

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:1107
+  auto *TrueConst =
+      dyn_cast<ConstantInt>(TrueVal->getAggregateElement(IndexVal));
+  auto *FalseConst =
----------------
Why do these have to be ConstantInt? Surely it should work with floats too (should have a test for this) or any other kind of Constant?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137934/new/

https://reviews.llvm.org/D137934