[PATCH] D137947: [AArch64][SVE] Add instcombine to convert ptest.last/first to ptest.any

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 07:57:58 PST 2022


c-rhodes accepted this revision.
c-rhodes added a comment.
This revision is now accepted and ready to land.

just one suggestion but otherwise LGTM, cheers



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:983
+  Builder.SetInsertPoint(&II);
+
+  if (PgVal == OpVal &&
----------------
perhaps worth adding a comment describing the combine?

```PTEST_<FIRST|LAST>(X, X) is equivalent to PTEST_ANY(X, X).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137947/new/

https://reviews.llvm.org/D137947



More information about the llvm-commits mailing list