[PATCH] D137932: [GlobalIsel][AMDGPU] Changing legalize rule for G_{UADDO|UADDE|USUBO|USUBE|SADDE|SSUBE}

Yashwant Singh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 07:16:56 PST 2022


yassingh added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-sadde.mir:2
 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
 # RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=fiji -O0 -run-pass=legalizer -global-isel-abort=0 %s -o - | FileCheck %s
 
----------------
Petar.Avramovic wrote:
> I think that -global-isel-abort=0 in no longer required since test should compile now with the addition of narrow scalar of s64 to s32.
> Can you check the other tests?
Yes the tests compile without -global-isel-abort=0, updating both tests containing it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137932/new/

https://reviews.llvm.org/D137932



More information about the llvm-commits mailing list