[PATCH] D137913: [X86] Rewrite `getScalarizationOverhead()`

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 06:32:47 PST 2022


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:4424
         const int CostValue = *LT.first.getValue();
         assert(CostValue >= 0 && "Negative cost!");
+        assert((SizeInBits % 128) == 0 && "Illegal vector");
----------------
RKSimon wrote:
> This confused me - we might need a better term that CostValue now (NumLegalVectors?)
Yeah, i was wondering if i should make naming more correct, but made the wrong choice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137913/new/

https://reviews.llvm.org/D137913



More information about the llvm-commits mailing list