[PATCH] D137925: [AArch64] FNMUL

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

In D137925#3924452 <https://reviews.llvm.org/D137925#3924452>, @dmgreen wrote:

> NoHonorSignDependentRounding is the old way of doing things - it should be based on fastmath flags nowadays. Or at least I've not heard of NoHonorSignDependentRounding before and it seems to be only used in the Arm backend at the moment.
>
> This alive test seems to suggest that we can just always do the transform: https://alive2.llvm.org/ce/z/5-LdY1. Which I think sounds OK considering that it is a fneg. Do you know why HonorSignDependentRounding is needed? Was it just copied from Arm?

Thanks Dave.
Yeah, I also think we don't need `NoHonorSignDependentRounding`, but just added it to be consistent with ARM. The default is off, so it will do transform, which is why I didn't mind adding it... but you're right it's probably better not to add it if it is the old way of doing things. So I will remove it from here. Let's then also remove it for ARM, but we can do that separately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137925/new/

https://reviews.llvm.org/D137925