[PATCH] D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/lib/DebugInfo/LogicalView/Readers/LVBinaryReader.cpp:383
+  LVAddress FirstAddress = Address;
+  LVLines *Instructions = new LVLines();
+
----------------
CarlosAlbertoEnciso wrote:
> vitalybuka wrote:
> > Why this code does not use unique_ptr<> ?
> The memory management issue has been already discussed in the reviews and it would be addressed once the series of patches are landed.
@vitalybuka: A new patch has been uploaded that addresses the memory management issues: https://reviews.llvm.org/D137933 (10 Smart pointers). With that patch the tool uses only smart pointers. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125783/new/

https://reviews.llvm.org/D125783