[PATCH] D137924: [TargetParser] Split AArch64TargetParser from ARMTargetParser

[Tomas Matheson via Phabricator via llvm-commits]

tmatheson marked an inline comment as done.
tmatheson added inline comments.


================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.h:85
 
-const ARM::ArchNames<ArchKind> AArch64ARCHNames[] = {
-#define AARCH64_ARCH(NAME, ID, CPU_ATTR, SUB_ARCH, ARCH_ATTR, ARCH_FPU,        \
-                     ARCH_BASE_EXT)                                            \
-  {NAME,                                                                       \
-   sizeof(NAME) - 1,                                                           \
-   CPU_ATTR,                                                                   \
-   sizeof(CPU_ATTR) - 1,                                                       \
-   "+" SUB_ARCH,                                                               \
-   sizeof(SUB_ARCH),                                                           \
-   ARM::FPUKind::ARCH_FPU,                                                     \
-   ARCH_BASE_EXT,                                                              \
-   AArch64::ArchKind::ID,                                                      \
-   ARCH_ATTR},
+template <typename T> struct ArchNames {
+  const char *NameCStr;
----------------
lenary wrote:
> Does this still need to be templated, if the implementation is not shared between aarch64 and arm?
It doesn't. I have some follow up patches to address stuff like this, but trying to keep this patch to just moving code around unchanged, as far as possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137924/new/

https://reviews.llvm.org/D137924