[PATCH] D137866: [Coroutines] Do not add allocas for retcon coroutines

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added a comment.

In D137866#3924203 <https://reviews.llvm.org/D137866#3924203>, @jsilvanus wrote:

> Not your code, but:
>
> Maybe it would be cleaner to check whether we need a frame object at all instead of adding special case handling for allocas?
> Then, based on that condition, we could skip setup of the frame type and pointer, and leave the alloca's unchanged.
>
> If that's too much of a change, I'm fine with the proposed change, as it just fixes the existing condition.

I committed this for now as it just extends the existing handling for async to retcon. I’ll take a look at implementing your suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137866/new/

https://reviews.llvm.org/D137866