[PATCH] D134354: [AMDGPU][GlobalISel] Support mad/fma_mix selection

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 6 23:48:40 PST 2022


Pierre-vh updated this revision to Diff 473579.
Pierre-vh added a comment.

Abandoning D135145 <https://reviews.llvm.org/D135145> as we can't really decide whether it's a good or bad thing.
There's a couple of regressions then but nothing blocking landing afaik.
@arsenm can you confirm this is good to land? For the remainingg cases I'll add them to my notes and try to come up with something when time allows


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134354/new/

https://reviews.llvm.org/D134354

Files:
  llvm/lib/Target/AMDGPU/AMDGPUGISel.td
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
  llvm/lib/Target/AMDGPU/VOP3PInstructions.td
  llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-add-ext-fma.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-add-ext-mul.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-sub-ext-mul.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-sub-ext-neg-mul.ll
  llvm/test/CodeGen/AMDGPU/mad-mix-hi.ll
  llvm/test/CodeGen/AMDGPU/mad-mix-lo.ll
  llvm/test/CodeGen/AMDGPU/mad-mix.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134354.473579.patch
Type: text/x-patch
Size: 284680 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221107/789166a7/attachment-0001.bin>


More information about the llvm-commits mailing list