[PATCH] D137410: [AArch64] Add SME2.1 target feature for Armv9-A 2022 Architecture Extension

[David Sherwood via Phabricator via llvm-commits]

david-arm marked an inline comment as done.
david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:169
+    : Predicate<"Subtarget->hasSVE2p1() || Subtarget->hasSME2p1()">,
+                 AssemblerPredicate<(any_of FeatureSME2p1, FeatureSVE2p1), "sme2p1 or sve2p1">;
 // A subset of NEON instructions are legal in Streaming SVE execution mode,
----------------
paulwalker-arm wrote:
> Can this be `AssemblerPredicateWithAll`? Is this a convent time to fix the other SVE2p1 related instances where we erroneously use `AssemblerPredicate`?
I guess it's never a convenient time to be honest. :) I've changed this, but as a consequence the patch now includes changes to all the existing SVE2p1 tests too to fix up the RUN lines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137410/new/

https://reviews.llvm.org/D137410