[PATCH] D137341: [VectorCombine] widen a load with subvector insert

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 6 07:36:31 PST 2022


RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:279
+
+  auto *Load = dyn_cast<LoadInst>(Shuf->getOperand(0));
+  if (!canWidenLoad(Load, TTI))
----------------
Do we need to check for cases where the identity comes from the second operand? IIRC we got burnt by something similar recently.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137341/new/

https://reviews.llvm.org/D137341



More information about the llvm-commits mailing list