[PATCH] D137454: [InstCombine] Avoid passing pow attributes to sqrt

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 6 06:15:44 PST 2022


spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:2165
+      AttributeList Attrs;
+      Sqrt = getSqrtCall(Base, Attrs, Pow->doesNotAccessMemory(), M, B, TLI);
       if (!Sqrt)
----------------
spatel wrote:
> Do we need to name the default/empty AttributeList if this is the only use? 
> Ie, can the code be shorter? 
>       Sqrt = getSqrtCall(Base, AttributeList(), Pow->doesNotAccessMemory(), M, B, TLI);
I tried to make the existing code around here easier to understand with:
bff6880a5f89


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137454/new/

https://reviews.llvm.org/D137454



More information about the llvm-commits mailing list