[llvm] 6106816 - Revert "[llvm] [cmake] Set EXCLUDE_FROM_ALL on gtest and TestingSupport"

Michał Górny via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 6 01:06:37 PDT 2022


Author: Michał Górny
Date: 2022-11-06T09:06:16+01:00
New Revision: 6106816459463072b862d4406f7e010a5b9cddb2

URL: https://github.com/llvm/llvm-project/commit/6106816459463072b862d4406f7e010a5b9cddb2
DIFF: https://github.com/llvm/llvm-project/commit/6106816459463072b862d4406f7e010a5b9cddb2.diff

LOG: Revert "[llvm] [cmake] Set EXCLUDE_FROM_ALL on gtest and TestingSupport"

This reverts commit b6be37b0be5e1b524456c375700c76b7dae5171c.  Still
breaks flang.

Added: 
    

Modified: 
    llvm/lib/Testing/Support/CMakeLists.txt
    llvm/utils/unittest/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Testing/Support/CMakeLists.txt b/llvm/lib/Testing/Support/CMakeLists.txt
index 385d8eca2daa..81774eb171ca 100644
--- a/llvm/lib/Testing/Support/CMakeLists.txt
+++ b/llvm/lib/Testing/Support/CMakeLists.txt
@@ -1,7 +1,3 @@
-# Do not build unittest libraries automatically, they will be pulled in
-# by unittests if these are built.
-set(EXCLUDE_FROM_ALL ON)
-
 add_llvm_library(LLVMTestingSupport
   Annotations.cpp
   Error.cpp

diff  --git a/llvm/utils/unittest/CMakeLists.txt b/llvm/utils/unittest/CMakeLists.txt
index 302e9e0e8440..0e54e0e57c35 100644
--- a/llvm/utils/unittest/CMakeLists.txt
+++ b/llvm/utils/unittest/CMakeLists.txt
@@ -38,10 +38,6 @@ if (HAVE_LIBPTHREAD)
   list(APPEND LIBS pthread)
 endif()
 
-# Do not build unittest libraries automatically, they will be pulled in
-# by unittests if these are built.
-set(EXCLUDE_FROM_ALL ON)
-
 add_llvm_library(llvm_gtest
   googletest/src/gtest-all.cc
   googlemock/src/gmock-all.cc


        


More information about the llvm-commits mailing list