[PATCH] D137482: [LoongArch] Support parsing target specific flags for MIR

[wanglei via Phabricator via llvm-commits]

wangleiat added inline comments.


================
Comment at: llvm/test/CodeGen/LoongArch/mir-target-flags.ll:3
+; RUN:     --relocation-model=pic %s -o %t.mir
+; RUN: llc --mtriple=loongarch64 --run-pass loongarch-prera-expand-pseudo \
+; RUN:     %t.mir -o - | FileCheck %s
----------------
wangleiat wrote:
> MaskRay wrote:
> > `llc --mtriple=loongarch64 --run-pass loongarch-prera-expand-pseudo ` does not change the output. Is it needed?
> > `llc --mtriple=loongarch64 --run-pass loongarch-prera-expand-pseudo ` does not change the output. Is it needed?
> 
> Thanks for your review. Yes, it is necessary. In fact, this step is the real test for parsing target flags.
> `llc --mtriple=loongarch64 --run-pass loongarch-prera-expand-pseudo ` does not change the output. Is it needed?




================
Comment at: llvm/test/CodeGen/LoongArch/mir-target-flags.ll:3
+; RUN:     --relocation-model=pic %s -o %t.mir
+; RUN: llc --mtriple=loongarch64 --run-pass loongarch-prera-expand-pseudo \
+; RUN:     %t.mir -o - | FileCheck %s
----------------
wangleiat wrote:
> wangleiat wrote:
> > MaskRay wrote:
> > > `llc --mtriple=loongarch64 --run-pass loongarch-prera-expand-pseudo ` does not change the output. Is it needed?
> > > `llc --mtriple=loongarch64 --run-pass loongarch-prera-expand-pseudo ` does not change the output. Is it needed?
> > 
> > Thanks for your review. Yes, it is necessary. In fact, this step is the real test for parsing target flags.
> > `llc --mtriple=loongarch64 --run-pass loongarch-prera-expand-pseudo ` does not change the output. Is it needed?
> 
> 
> > `llc --mtriple=loongarch64 --run-pass loongarch-prera-expand-pseudo ` does not change the output. Is it needed?
> 
> Thanks for your review. Yes, it is necessary. In fact, this step is the real test for parsing target flags.

I seem to have misunderstood your meaning, maybe I don't need that pass? It may not be needed, I will verify and modify it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137482/new/

https://reviews.llvm.org/D137482