[PATCH] D135427: [LTO] Make local linkage GlobalValue in non-prevailing COMDAT available_externally

Sat Nov 5 14:57:19 PDT 2022

dblaikie added a comment.

In D135427#3910193 <https://reviews.llvm.org/D135427#3910193>, @MaskRay wrote:

> In D135427#3910121 <https://reviews.llvm.org/D135427#3910121>, @dblaikie wrote:
>
>> "can happen and will cause a Verifier failure" - could you clarify further what that means? A pass, given verified IR, shouldn't ever produce verifier-failing IR, right?
>
> GlobalAlias in a non-prevailing COMDAT is not correctly handled today (may crash or spuriously succeed). This patch makes it correct for likely all cases Clang CodeGen produces (when `C5/D5` constructor/destructor  aliases are used).

Ah, OK, sorry - incremental improvement then, fair enough. Thanks for the context!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135427/new/

https://reviews.llvm.org/D135427