[PATCH] D137441: [IR] Allow available_externally GlobalAlias

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:824
+    } else {
+      Check(!GV->isDeclaration(), "Alias must point to a definition", &GA);
+    }
----------------
nikic wrote:
> Shouldn't this be isDeclarationForLinker?
`hasAvailableExternallyLinkage` has precluded one condition of `isDeclarationForLinker` so `isDeclaration` suffices.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137441/new/

https://reviews.llvm.org/D137441