[PATCH] D137441: [IR] Allow available_externally GlobalAlias

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

For the record, the current restriction was introduced in https://github.com/llvm/llvm-project/commit/8934577171b967cc23186c2ffa0a0c4b54a8d992. The commit message mentions that available_externally aliases, if introduced, should always have a declaration-for-linker aliasee. Just want to confirm that it is fine to not have that restriction, as implemented here.



================
Comment at: llvm/lib/IR/Verifier.cpp:824
+    } else {
+      Check(!GV->isDeclaration(), "Alias must point to a definition", &GA);
+    }
----------------
Shouldn't this be isDeclarationForLinker?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137441/new/

https://reviews.llvm.org/D137441