[PATCH] D135427: [LTO] Make local linkage GlobalValue in non-prevailing COMDAT available_externally

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 4 18:08:59 PDT 2022


MaskRay updated this revision to Diff 473384.
MaskRay marked an inline comment as done.
MaskRay added a comment.

rebase
add an assert (reachable in a corner case, but ok to miss - Verifier.cpp will catch it anyway. assert just improves diagnostics).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135427/new/

https://reviews.llvm.org/D135427

Files:
  llvm/lib/LTO/LTO.cpp
  llvm/lib/Transforms/IPO/FunctionImport.cpp
  llvm/test/LTO/Resolution/X86/comdat-mixed-lto.ll
  llvm/test/ThinLTO/X86/Inputs/linkonce_resolution_comdat.ll
  llvm/test/ThinLTO/X86/constructor-alias.ll
  llvm/test/ThinLTO/X86/linkonce_resolution_comdat.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135427.473384.patch
Type: text/x-patch
Size: 12340 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221105/7eae805e/attachment.bin>


More information about the llvm-commits mailing list