[PATCH] D137360: [Linker] Remove nocallback attribute while linking

[Gulfem Savrun Yeniceri via Phabricator via llvm-commits]

gulfem added a comment.

In D137360#3907158 <https://reviews.llvm.org/D137360#3907158>, @nhaehnle wrote:

> This change needs a test case. It's usually best to just pre-commit the test case and rebase this change on top of it, so that the effect on the newly added test becomes clear. You normally don't need to open a Phabricator review for the added test.

Done!

In D137360#3907031 <https://reviews.llvm.org/D137360#3907031>, @jdoerfert wrote:

> I somewhat assume we could remove the attribute whenever we actually move a function (lazy linking) rather than for all in the module.
> Other than that I'm happy with dropping nocallback *and* inacc* (see https://reviews.llvm.org/D131628#3724307 for the latter).

There is a recent change that drops `argmemonly`, `inaccessiblememonly` and `inaccessiblemem_or_argmemonly` attributes (https://reviews.llvm.org/D135780). So, we do not need to apply this change to them anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137360/new/

https://reviews.llvm.org/D137360