[PATCH] D137441: [IR] Allow available_externally GlobalAlias

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:820
+    Check(GA.hasAvailableExternallyLinkage() || !GV->isDeclarationForLinker(),
+          "Alias must point to a definition", &GA);
 
----------------
MaskRay wrote:
> nikic wrote:
> > Why is an available_externally alias allowed to point to a declaration?
> An available_externally alias may refer to another available_externally GlobalValue. This is the case when an alias is in a non-prevailing COMDAT after my pending ThinLTO change.
If the aliasee is available_externally you should check that the alias is as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137441/new/

https://reviews.llvm.org/D137441