[PATCH] D137407: [GlobalIsel] Handle carry output generated in narrowScalarAddSub legalize action

Yashwant Singh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 4 10:03:52 PDT 2022


yassingh added a comment.

In D137407#3908174 <https://reviews.llvm.org/D137407#3908174>, @foad wrote:

> In D137407#3907766 <https://reviews.llvm.org/D137407#3907766>, @yassingh wrote:
>
>> Where should I add the tests for this change?
>
> Does AMDGPU use this code? If so you could put something in `test/CodeGen/AMDGPU/GlobalISel/legalize-add.mir`.

It doesn't. I am exploring the idea of legalizing wide G_UADDO instruction using this //narrowScalarAddSub// legalize action(as of now it is lowered to G_ADD first) and noticed it does not handle carry generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137407/new/

https://reviews.llvm.org/D137407



More information about the llvm-commits mailing list