[PATCH] D137388: [X86] Add necessary check isReg() when updating LiveVariables in convertToThreeAddress

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:1772
+      if (Op.isReg() && (Op.isDead() || Op.isKill()))
         LV->replaceKillInstruction(Op.getReg(), MI, *NewMI);
     }
----------------
By inspection - the getReg below will assert if its isn't a register so this should be OK.

@foad might have a suggestion regarding alternative ways to test though? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137388/new/

https://reviews.llvm.org/D137388