[PATCH] D137425: [M68k] Add predicates `AtLeastM680x0`

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 4 09:19:54 PDT 2022


myhsu added a reviewer: myhsu.
myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kInstrInfo.td:432
 def IsNotPIC     : Predicate<"!TM.isPositionIndependent()">;
 def IsM68000     : Predicate<"Subtarget.IsM68000()">;
 def IsM68010     : Predicate<"Subtarget.IsM68010()">;
----------------
Could you remove these IsM680X0 predicates (they're wrong anyway) and refactor their references (there are only a few) to use the new one?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137425/new/

https://reviews.llvm.org/D137425



More information about the llvm-commits mailing list