[PATCH] D135780: [IR] Switch everything to use memory attribute
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 4 01:56:11 PDT 2022
nikic marked 5 inline comments as done.
nikic added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1476
- ReadOnlyNoneAttrs.addAttribute(Attribute::ReadOnly)
- .addAttribute(Attribute::ReadNone);
+ ReadOnlyNoneAttrs.addAttribute(Attribute::Memory);
----------------
jdoerfert wrote:
> This seems more pessimistic. Unsure if it makes a difference.
It likely doesn't matter in practice, but I should at least add a TODO...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135780/new/
https://reviews.llvm.org/D135780
More information about the llvm-commits
mailing list