[PATCH] D137230: [XCOFF] avoid unnecessary Fixups when -function-sections is enabled.

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 3 22:33:57 PDT 2022


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2223
         &(MF->getFunction()), TM);
+    // If the FuncSectSym is the csect itself, the difference between FuncEnd
+    // and FuncSectSym is an absolute value. To avoid evaluating an MCExpr for
----------------
Can we address this where the MCExpr is handled instead? There may be more ways a similar expression involving a csect as an operand is involved in the future (e.g., assembly parsing).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137230/new/

https://reviews.llvm.org/D137230



More information about the llvm-commits mailing list