[PATCH] D137360: [Linker] Remove nocallback attribute while linking

[Daniel Thornburgh via Phabricator via llvm-commits]

mysterymath added inline comments.


================
Comment at: llvm/lib/Linker/LinkModules.cpp:530
 
+  // Since nocallback function attribute is treated as a hint on
+  // the module level, it is removed while linking modules.
----------------
mysterymath wrote:
> We'll also need to do this with inaccessiblememonly, inaccessiblemem_or_argmemonly, and the inaccessiblemem option for the memory() attribute.
Scratch this, it looks like the FunctionAttrs pass rewrites these based on the results of the bitcode link.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137360/new/

https://reviews.llvm.org/D137360