[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 3 14:22:01 PDT 2022


jhuber6 added inline comments.


================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1262-1265
+    if (identify_magic((*BufferOrErr)->getBuffer()) ==
+        file_magic::elf_shared_object)
+      continue;
+
----------------
tra wrote:
> jhenderson wrote:
> > This change seems not really part of the patch, since it's touching `clang` but the patch is for `llvm-objdump`.
> +1 to landing this separately, possibly with a relevant test.
I put it in a separate commit but it seems arcanist squashed it in the background.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136796/new/

https://reviews.llvm.org/D136796



More information about the llvm-commits mailing list